fix(cli): skip checks ndk when NDK_HOME set #14398
Open
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, the way to ensure NDK installation is to check whether the ndk folder exists under the
$ANDROID_HOMEdirectory. If it exists, theNDK_HOMEenvironment variable is set; otherwise, the NDK will be installed. This approach overrides any user-setNDK_HOMEvariable. However, on some systems (like NixOS), the NDK installed via package managers may not be located in the$ANDROID_HOME/ndkdirectory but elsewhere. Ignoring theNDK_HOMEvariable would render such system-installed NDKs unusable.This PR bypasses the NDK check when
NDK_HOMEhas already been set.