Skip to content

Conversation

@Andrew15-5
Copy link
Contributor

@Andrew15-5 Andrew15-5 commented Jul 28, 2025

Fixes small issue from #13893.

1 is considered the default value for this field. Empty string will result in "-." sequence in a file name, which is not desired.

Cc @FabianLars


Ensure that all your commits are signed https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

It's great that I already have this, otherwise it's strange to demand.

Ensure cargo test and cargo clippy passes.

Well, apparently the dev has tests passing, but for me dev does not pass, so is this branch.

logs
test tests::resolve_acl ... FAILED

failures:

---- tests::resolve_acl stdout ----
cargo:PERMISSION_FILES_PATH=/tmp/ping-permission-files
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: crates/tests/acl/src/../fixtures/snapshots/acl_tests__tests__basic-ping.snap
Snapshot: basic-ping
Source: crates/tests/acl/src/lib.rs:71
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Expression: resolved
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
    0     0 │ Resolved {
          1 │+    has_app_acl: false,
    1     2 │     allowed_commands: {
    2     3 │         "plugin:ping|ping": [
    3     4 │             ResolvedCommand {
    4     5 │                 context: Local,
────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
To update snapshots run `cargo insta review`
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

Also couldn't compile test binary without using flake that I used here that is mostly from the Dioxus repo. I'd consider adding flake with envrc directly or providing them in a contributing file or in a non-root directory ("nix" or something). (I use NixOS btw.)

1 is considered the default value for this field. Empty string will
result in "-." sequence in a file name, which is not desired.
@Andrew15-5 Andrew15-5 requested a review from a team as a code owner July 28, 2025 18:40
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Jul 28, 2025
@github-actions
Copy link
Contributor

Package Changes Through 9f320f5

There are 5 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri with patch, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.6.0 2.7.0
tauri-bundler 2.5.2 2.5.3
tauri-runtime 2.7.1 2.7.2
tauri-runtime-wry 2.7.2 2.7.3
tauri-codegen 2.3.1 2.3.2
tauri-macros 2.3.2 2.3.3
tauri-plugin 2.3.1 2.4.0
tauri-build 2.3.1 2.3.2
tauri 2.7.0 2.7.1
@tauri-apps/cli 2.7.1 2.8.0
tauri-cli 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u

@FabianLars FabianLars merged commit bc6b125 into tauri-apps:dev Jul 29, 2025
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Jul 29, 2025
@Andrew15-5 Andrew15-5 deleted the default-rpm-release branch July 30, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants