Fix/ts 7676/sub query with window main

[facetosea]

Description

Please briefly describe the code changes in this pull request.

Jira: https://jira.taosdata.com:18080/browse/TD-

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @facetosea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the handling of window functions when used with subqueries. The core purpose is to ensure that ordering information specified within subqueries is correctly interpreted and applied throughout the query processing pipeline, from parsing to logical plan optimization. This leads to more accurate results for complex windowing operations and enhances the overall robustness of the query engine, particularly for advanced time-series analytics.

Highlights

• Enhanced Order Handling: Modified the EOrder enum to include ORDER_UNKNOWN and updated SSelectStmt to store explicit order types (ASC/DESC) for timeLineFromOrderBy, replacing a boolean flag.
• Window Boundary Correction: Implemented a check and swap mechanism in timewindowoperator.c to ensure correct skey and ekey ordering for window boundaries.
• Subquery Order Propagation: Introduced a new function resetOrderBySubqueryOrder in the parser to correctly identify and propagate the ORDER BY clause's direction from subqueries to the main query's window function processing.
• Logical Plan Optimization: Added a KeepGroupAction optimization rule to the planner, which ensures appropriate grouping actions are maintained for window logic nodes, improving query execution efficiency.
• Refactored Test Suite: Replaced the test_interval_bug_ts5400.py test file with a new test_interval_bugfix.py that includes comprehensive tests for TS-7676 covering various window types and ORDER BY scenarios within subqueries.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fix for handling subqueries with window functions, specifically addressing how ORDER BY clauses in subqueries affect timeline alignment. The key changes include modifying SSelectStmt.timeLineFromOrderBy from a boolean to an integer to store the order direction, and adding logic to correctly propagate this order information. Additionally, a new optimization rule KeepGroupAction is introduced. The changes are well-supported by a comprehensive new test file that covers various scenarios. My feedback includes suggestions for improving code robustness, removing dead code, and cleaning up the new test file.

[dapan1121]

这个逻辑不清晰

[dapan1121]

为什么不直接使用子查询的结果是否有序字段