Skip to content

Fix Android build on CI#157

Merged
uilianries merged 6 commits into
taocpp:mainfrom
uilianries:ci/fix-android-build
Dec 29, 2024
Merged

Fix Android build on CI#157
uilianries merged 6 commits into
taocpp:mainfrom
uilianries:ci/fix-android-build

Conversation

@uilianries

Copy link
Copy Markdown
Member

This PR not only fixes the current build for Android but also simplifies its use by consuming the NDK only from the official Ubuntu docker image provided by Github Actions.

Still, there is a window for improvement, like, caching PEGTL to reduce the build time, but this is a second step for a future PR.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries self-assigned this Dec 29, 2024
@uilianries uilianries changed the title Use Github integrated Android NDK only [ci] Use Github integrated Android NDK only in order to fix the current build Dec 29, 2024
@uilianries

Copy link
Copy Markdown
Member Author

@uilianries uilianries merged commit 821c7d8 into taocpp:main Dec 29, 2024
@uilianries uilianries changed the title [ci] Use Github integrated Android NDK only in order to fix the current build Fix Android build on CI Dec 29, 2024
@codecov

codecov Bot commented Dec 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (d5fc49b) to head (2225183).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         257      257           
  Lines        9191     9191           
  Branches      804      804           
=======================================
  Hits         6803     6803           
  Misses       1785     1785           
  Partials      603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant