Resolve texture imports using final merged scene #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textures referenced as global properties inside imported scenes now resolve against the base scene path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve named textures using final merged scene. This fixes cases where named textures defined via global properties in imported scenes would be interpreted as URLs, if the texture name was not yet defined in the imported scene, but which will be defined in the final merged scene (e.g. the texture name is defined by an ancestor/importing scene, but not the descendant/imported scene where it is used).
See #748 for issue, and tangrams/tangram-es#2201 for Tangram ES fix.