refactor(retry): migrate from backoff to tenacity#1000
refactor(retry): migrate from backoff to tenacity#1000Kevin James (TheKevJames) wants to merge 3 commits intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the retry mechanism across the codebase, replacing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project's retry logic from the abandoned backoff library to tenacity. The changes span across dependency configurations, application code, test files, and documentation, ensuring a consistent and necessary update. The migration to tenacity is well-executed, with retry policies correctly translated. I've included a couple of suggestions to refactor duplicated retry logic in a test file for improved maintainability and conciseness.
2453294 to
7687599
Compare
3e68cf4 to
67caf2b
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
40f8b72 to
0a75808
Compare
Summary
backoffis now abandoned and starting to throw errors in newer Pythonversions (see #999), so we need to consider an alternative. After playing with
tenacity and stamina, and evaluating a few others, it seems like
tenacityisa pretty nice fit it terms of useability vs simplicity and slotting into our
system.