Update load_csv.py #229
Open
Update load_csv.py #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant CSV Loading: The main issue with the original approach is that the CSV is being loaded twice — once for metadata_columns and once for NECESSARY_COLS. This leads to repeated IO operations and potential inefficiency. Since the columns are being merged in the same function, you can load the CSV once and manage the metadata combination more efficiently.
Instead of I loaded all metadata columns in one with loader_metadata = CSVLoader(path, metadata_columns=NECESSARY_COLS + metadata_columns)