Refactor load csv to use langchain's CSVLoader #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgabs
changed the title
|
it's a good idea to wait for #203 enter so this refactor can enter without breaking the current behavior. |
vmesel
approved these changes
Jun 4, 2024
|
@lgabs as we spoke in WhatsApp, after @mcbianconi's PR it became easier to test the load_csv. Could you please solve the failing tests on this fork so we can proceed with the merge? |
lgabs
commented
Jun 5, 2024
|
@lgabs great job! just tested here, looks amazing! |
lgabs
force-pushed
the
update-load-csv-for-langchain-csv-loader
branch
from
f02ba48 to
c0b1ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #199