Skip to content

Fix reward scaler when run on varied episode lengths #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Fix reward scaler when run on varied episode lengths #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions d3rlpy/preprocessing/reward_scalers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,9 @@ def fit_with_trajectory_slicer(
).rewards
for episode in episodes
]
self.mean = float(np.mean(rewards))
self.std = float(np.std(rewards))
flat_rewards = np.concatenate(rewards)
self.mean = float(np.mean(flat_rewards))
self.std = float(np.std(flat_rewards))

def transform(self, x: torch.Tensor) -> torch.Tensor:
assert self.built
Expand Down