fix: resolve timeout and performance issues in buffer write mode and AOF writes#893
Merged
suxb201 merged 2 commits intotair-opensource:v4from Dec 3, 2024
Merged
fix: resolve timeout and performance issues in buffer write mode and AOF writes#893suxb201 merged 2 commits intotair-opensource:v4from
suxb201 merged 2 commits intotair-opensource:v4from
Conversation
…AOF writes - resolve timeout issue after small-batch writes in buffer mode - address high disk usage and write bottleneck caused by forced AOF file sync
suxb201
requested changes
Dec 2, 2024
Member
suxb201
left a comment
suxb201
left a comment
There was a problem hiding this comment.
- 更倾向于原先写法一点，新的改动带来高延迟风险。
- 后续有机会可以把 sendCount 改成 sendBytes，flush 不在意 count，只在意 bytes；也能避免 100 条大命令导致 OOM 的场景。
- Trigger flush based on 64k data size instead of packet count - Improve timer reset mechanism to minimize latency under high load feat: enhance RDB file receiving logs - Add log to display the current received RDB size in real-time
suxb201
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resolve timeout and performance issues in buffer write mode and AOF writes
resolve timeout issue after small-batch writes in buffer mode
address high disk usage and write bottleneck caused by forced AOF file sync
解决redis_writer缓冲区模式下小批量写入后的超时不提交问题
解决强制AOF文件同步导致的磁盘占用高和写入瓶颈问题