Skip to content

fix: discard RDB data when sync_rdb=false instead of writing to disk #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suxb201 merged 1 commit into from
Mar 2, 2026
Merged

fix: discard RDB data when sync_rdb=false instead of writing to disk #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion internal/reader/sync_standalone_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,21 @@ func (r *syncStandaloneReader) receiveRDB() string {
}
marker = strings.TrimSpace(marker)

r.stat.Status = kReceiveRdb

// When sync_rdb is disabled, we still must receive the RDB payload from the source
// (required by Redis replication protocol), but we discard it instead of writing to disk.
if !r.opts.SyncRdb {
log.Infof("[%s] sync_rdb is disabled. Receiving and discarding RDB payload (required by replication protocol).", r.stat.Name)
if strings.HasPrefix(marker, "EOF") {
r.receiveRDBWithDiskless(marker, io.Discard)
} else {
r.receiveRDBWithoutDiskless(marker, io.Discard)
}
log.Infof("[%s] RDB payload discarded. timeUsed=[%.2f]s", r.stat.Name, time.Since(timeStart).Seconds())
return ""
}

// create rdb file
rdbFilePath, err := filepath.Abs(r.stat.Name + "/dump.rdb")
if err != nil {
Expand All @@ -351,7 +366,6 @@ func (r *syncStandaloneReader) receiveRDB() string {
}

// receive rdb
r.stat.Status = kReceiveRdb
if strings.HasPrefix(marker, "EOF") {
log.Infof("[%s] source db supoort diskless sync capability.", r.stat.Name)
r.receiveRDBWithDiskless(marker, rdbFileHandle)
Expand Down
Loading