Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ac4aa6178
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
test_local.sh
Outdated
| if [ $# -eq 0 ]; then | ||
| pybbt cases --verbose | ||
| else | ||
| pybbt cases --verbose "$@" |
There was a problem hiding this comment.
Accept a single pybbt target when args are provided
When arguments are passed, this branch still prepends cases, which gives pybbt two positional paths (cases and the user-supplied one). pybbt --help defines only one positional file_or_dir, so ./test_local.sh cases/rdb.py fails with unrecognized arguments instead of running that file as documented. This breaks the new “run specific test file” workflow whenever the user passes a positional target.
Useful? React with 👍 / 👎.
1. Fix build.sh to use GO_LDFLAGS instead of LDFLAGS to avoid conflicts
with Homebrew's LDFLAGS environment variable (e.g., from flex package)
2. Add test_local.sh for easy local testing on macOS/Linux
- Automatically detects Redis version from PATH
- Runs tests without modules flag (suitable for Homebrew Redis)
3. Improve cluster test robustness in tests/helpers/cluster.py
- Add _wait_cluster_ready() method that verifies writes work on all slots
- This prevents CLUSTERDOWN errors caused by cluster gossip not fully
propagating before tests start writing
Usage:
./test_local.sh # Run all tests
./test_local.sh cases/rdb.py # Run specific test file
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1ac4aa6 to
63a27b8
Compare
Summary
build.shto useGO_LDFLAGSinstead ofLDFLAGSto avoid conflicts with Homebrew's environment variablestest_local.shfor easy local testing on macOS/Linux with Homebrew RedisChanges
build.sh: Changed
LDFLAGStoGO_LDFLAGSto prevent conflicts when user's shell hasLDFLAGSset by Homebrew packages (e.g., flex)test_local.sh: New script for local testing
Usage
Test Results (macOS with Redis 8.2.1)
All 6 tests passed locally:
Test plan
🤖 Generated with Claude Code