Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
suxb201
force-pushed
the
feat-redis-8
branch
from
f7a6da0 to
d19ee50
Compare
suxb201
force-pushed
the
feat-redis-8
branch
from
d19ee50 to
43c2080
Compare
suxb201
force-pushed
the
feat-redis-8
branch
2 times, most recently
from
d2a96e7 to
a75480f
Compare
suxb201
force-pushed
the
feat-redis-8
branch
from
a75480f to
695f108
Compare
|
@codex review |
suxb201
force-pushed
the
feat-redis-8
branch
from
d25f5a5 to
d62c60b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| typeByte := dump[0] | ||
| anotherReader := strings.NewReader(dump[1 : len(dump)-10]) | ||
| o := types.ParseObject(anotherReader, typeByte, key) | ||
| // TODO: detect if server is Valkey and pass appropriate flag | ||
| // For now, assume Redis format (false) | ||
| o := types.ParseObject(anotherReader, typeByte, key, false) |
There was a problem hiding this comment.
When a key’s serialized DUMP exceeds TargetRedisProtoMaxBulkLen, this path rewrites the value by calling ParseObject(..., false), which forces the Redis 8 hash-expiration format. For Valkey 9 sources, type 22 hashes use the Valkey HASH_2 layout (field/value/8‑byte TTL), and ParseObject only switches to that decoding when isValkey is true. That means large Valkey hashes with field expiration will be mis-parsed (wrong TTLs or stream desync/panic) during scan-based migrations. This only happens in scan mode for large keys on Valkey 9+, but it will silently corrupt data or fail under those conditions.
Useful? React with 👍 / 👎.
1 participant
Uh oh!
There was an error while loading. Please reload this page.