-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CSS Parser: Handle string with semi-colon in custom properties. #18251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thecrypticace
merged 5 commits into
tailwindlabs:main
from
cduez:fix-string-custom-property
Jun 9, 2025
Merged
CSS Parser: Handle string with semi-colon in custom properties. #18251
thecrypticace
merged 5 commits into
tailwindlabs:main
from
cduez:fix-string-custom-property
Jun 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Jun 9, 2025
1 task
This was referenced Oct 28, 2025
This was referenced Nov 5, 2025
This was referenced Nov 7, 2025
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings are not parsed correctly for custom properties which makes the following CSS raise an
Unterminated string: ";"error:According to the spec, we should accept semi-colon as long as they are not at the top level.
Extract from: https://drafts.csswg.org/css-variables/#syntax
I was only able to reproduce with tailwindcss v4, the previous version seems to support this. This issue is mitigated by the fact that even if you want to use a data URL in a custom property, you would need to wrap the value in a
url()anyway:Which works perfectly fine with the current/latest version (v4.1.8).
The fix suggested is to share the same code between regular property and custom property when it comes to detect that the value is a string starting with a
SINGLE_QUOTEorDOUBLE_QUOTE. I have moved the existing code in afindEndStringIdxwhich returns the position of the ending single/double quote.