Ensure compound variants work with variants with multiple selectors#14016
Merged
Conversation
eac5259 to
9ec6f5a
Compare
9ec6f5a to
1a34d0a
Compare
1a34d0a to
462abc9
Compare
adamwathan
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
not-*andhas-*variants fail to generate correct CSS when given a custom variant using multiple selectors like so:Previously
not-hocus:underlinegenerated this — incorrectly including the utility inside the:not(…):Now it generates the following correct CSS:
This same issue applied to the
has-*variant as well which now generates: