Implement not-* variant with @media, @supports and @container variants#13995
Closed
RobinMalfait wants to merge 3 commits into
Closed
Implement not-* variant with @media, @supports and @container variants#13995RobinMalfait wants to merge 3 commits into
not-* variant with @media, @supports and @container variants#13995RobinMalfait wants to merge 3 commits into
Conversation
thecrypticace
approved these changes
Jul 12, 2024
5f3eced to
b1f3ff3
Compare
b1f3ff3 to
261cae5
Compare
Member
Author
|
Closed in favor of: #14743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
not-*variant worked with other variants that only included selectors, however some variants where only@media,@supports, and@containeris used, thenot-*variant would not work.This PR solves that by inverting the query using the
notkeyword.This allows us to use
not-print:flexwhich compiles to: