Support combining arbitrary shadows without a color with shadow color utilities#13876
Merged
Conversation
thecrypticace
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I discovered when live-streaming a few weeks ago that prevents code like this from working:
Currently in the v4 engine, arbitrary shadows require a color to be specified in the arbitrary value in order for shadow color utilities to properly replace the color. This was not the case in the v3 engine, and is definitely something we want to work in v4.
The fix is to append the color variable to the arbitrary shadow if no color can be parsed from the shadow value, instead of bailing if no color is found.