Inline @import rules in tailwindcss/index.css at publish time for better performance#13233
Merged
Conversation
This implementation is fairly simple right now, because we don't have to worry about resolving folders or modules since we don't use them.
This reverts commit 13a4640.
adamwathan
reviewed
Mar 13, 2024
Co-authored-by: Jordan Pittman <[email protected]>
Co-authored-by: Adam Wathan <[email protected]>
adamwathan
approved these changes
Mar 13, 2024
thecrypticace
approved these changes
Mar 13, 2024
RobinMalfait
changed the title
tailwindcss/index.css contents at publish time@import rules in tailwindcss/index.css at publish time for better performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way none of the tools using
@import "tailwindcss";have to resolve imports at "runtime" because it will already be inlined when it's published.This does increase the bundle size of the
tailwindcsspackage, but it's still going to be a very small package.