-
-
Notifications
You must be signed in to change notification settings - Fork 173
Add cache for known plugins #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { createRequire as req } from 'node:module' | ||
| import { expiringMap } from './expiring-map' | ||
|
|
||
| const localRequire = req(import.meta.url) | ||
|
|
||
| // This is a long-lived cache for resolved modules whether they exist or not | ||
| // Because we're compatible with a large number of plugins, we need to check | ||
| // for the existence of a module before attempting to import it. This cache | ||
| // is used to mitigate the cost of that check because Node.js does not cache | ||
| // failed module resolutions making repeated checks very expensive. | ||
| const resolveCache = expiringMap<string, string | null>(30_000) | ||
|
|
||
| export function resolveIn(id: string, paths: string[]) { | ||
| return localRequire.resolve(id, { | ||
| paths, | ||
| }) | ||
| } | ||
|
|
||
| export function maybeResolve(name: string) { | ||
| let modpath = resolveCache.get(name) | ||
|
|
||
| if (modpath === undefined) { | ||
| modpath = freshMaybeResolve(name) | ||
| resolveCache.set(name, modpath) | ||
thecrypticace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| return modpath | ||
| } | ||
|
|
||
| export async function loadIfExists<T>(name: string): Promise<T | null> { | ||
| let modpath = maybeResolve(name) | ||
|
|
||
| if (modpath) { | ||
| let mod = await import(name) | ||
| return mod.default ?? mod | ||
| } | ||
|
|
||
| return null | ||
| } | ||
|
|
||
| function freshMaybeResolve(name: string) { | ||
| try { | ||
| return localRequire.resolve(name) | ||
| } catch (err) { | ||
| return null | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.