Fix sorting inside dynamic custom attributes #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in the for loop for dynamicAttrs "attr.name" was added in the string template (which was undefined) while the required value was "attr" itself. e.g. tailwindAttributes: ["ui"], Before: staticAttrs: "class,ui" dynamicAttrs: ":class,v-bind:class,:undefined,v-bind:undefined" After: staticAttrs: "class,ui" dynamicAttrs: ":class,v-bind:class,:ui,v-bind:ui"
thecrypticace
changed the title
dynamicAttrs for custom attributes
thecrypticace
changed the title
dynamicAttrs for custom attributes
Contributor
|
lol oops — thanks |
Contributor
|
Released as v0.5.7 — may take a few for NPM to pick it up |
bronisMateusz
pushed a commit
to bronisMateusz/prettier-plugin-tailwindcss-drupal
that referenced
this pull request
Apr 16, 2025
…#225) * Fix `dynamicAttrs` in `options.js` * Add test --------- Co-authored-by: Jordan Pittman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the for loop for dynamicAttrs "attr.name" was added in the string template (which was undefined) while the required value was "attr" itself.
e.g. tailwindAttributes: ["ui"],
Before:
staticAttrs: "class,ui"
dynamicAttrs: ":class,v-bind:class,:undefined,v-bind:undefined"
After:
staticAttrs: "class,ui"
dynamicAttrs: ":class,v-bind:class,:ui,v-bind:ui"
fixes Prettier Plugin Tailwind within :ui={...} and [Prettier Plugin] Can't seem to get "tailwindAttributes" and/or "tailwindFunctions" to work?