policyfile: add SetAndGet method #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpminardi
reviewed
Feb 20, 2025
policyfile.go
Outdated
|
|
||
| // Set sets the [ACL] for the tailnet and returns the resulting [ACL]. | ||
| // etag is an optional value that, if supplied, will be used in the "If-Match" HTTP request header. | ||
| func (pr *PolicyFileResource) SetAndGet(ctx context.Context, acl any, etag string) (*ACL, error) { |
There was a problem hiding this comment.
Should we just modify the behaviour of Set to return the *ACL instead of adding a new method, or are you thinking there is worth in keeping both here to ease v1 -> v2 migration?
There was a problem hiding this comment.
I added a 2nd method for three reasons:
- To avoid breaking clients who already use the existing method
- To avoid doing work that the above clients don't need (i.e. deserializing the response JSON)
Setaccepts both anACLas well as a HuJSON string. For symmetry, that would imply thatSetwould return either anACLor a HuJSON string depending on what was passed in, meaning that the return type would have to beany, which isn't very ergonomic.
There was a problem hiding this comment.
Set accepts both an ACL as well as a HuJSON string
Having said that out loud, I'm now realizing that the new method does the same. Thinking ...
There was a problem hiding this comment.
Signature fixed.
oxtoacart
force-pushed
the
percy/corp22748-devices
branch
from
74a18f6 to
62faeb5
Compare
Add 'AdvertisedRoutes', 'EnabledRoutes' and 'ClientConnectivity' to the 'Device' type and add the method 'ListWithAllFields' to obtain Devices with those fields populated. Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/corp22748-policyfile
branch
from
a6b6284 to
f78cb7b
Compare
This variant of Set returns the resulting ACL with its updated ETag. Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/corp22748-policyfile
branch
from
f78cb7b to
2b21016
Compare
mpminardi
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant of Set returns the resulting ACL with its updated ETag.
Updates tailscale/corp#22748