Max/token exchange take 2 #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tailscale/terraform-provider-tailscale#485 Signed-off-by: mcoulombe <[email protected]>
oxtoacart
reviewed
Oct 17, 2025
client.go
Outdated
| } | ||
|
|
||
| // Wrap the HTTP client's transport with the federated-idetity-aware transport | ||
| c.HTTP.Transport = transport |
There was a problem hiding this comment.
Mutating the HTTP client that's passed in isn't great, as it may be used elsewhere.
There was a problem hiding this comment.
It turns out we can just make a new http.Client that takes the important bits from the original client, like here.
mcoulombe
force-pushed
the
max/token-exchange-take-2
branch
from
ef1a6ba to
9031f13
Compare
Signed-off-by: mcoulombe <[email protected]>
mcoulombe
force-pushed
the
max/token-exchange-take-2
branch
from
9031f13 to
f965ee1
Compare
oxtoacart
reviewed
Oct 17, 2025
| // When set along with IDTokenFunc, the client will use identity federation for authentication. | ||
| // For OAuth, if empty and ClientSecret is provided, the ClientID will be derived from the ClientSecret. | ||
| // Overwrites APIKey if set. | ||
| ClientID string |
There was a problem hiding this comment.
Instead of adding more and more parameters to the Client type, let's just make different pluggable authentication mechanisms and plug them into a single place like here.
oxtoacart
reviewed
Oct 17, 2025
| return client | ||
| } | ||
|
|
||
| // oauthTokenSource implements oauth2.TokenSource using client credentials flow. |
There was a problem hiding this comment.
Ha, I don't know how I missed that you did this already!
|
Closing, we'll use a slightly different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.