Restructure repo to allow importing v2 module using tailscale.com/client/tailscale/v2 #3
Conversation
Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/removev1
branch
from
b20f732 to
e9c75c2
Compare
README.md
Outdated
| @@ -1,17 +1,59 @@ | |||
| # tailscale-client-go | |||
| // Copyright (c) David Bond, Tailscale Inc, & Contributors | |||
There was a problem hiding this comment.
In other repos, e.g., OSS, we've done this by including a reference to the AUTHORS file and listing contributors there. That might be worth preserving here.
There was a problem hiding this comment.
We had some internal discussion with @willnorris about this back in September and settled on what we have for the OG tailscale-client-go repo. I'm inclined to leave that as-is here.
README.md
Outdated
|
|
||
| ## Current Version | ||
| [](https://pkg.go.dev/tailscale.com/client/tailscale/v2) | ||
| [](https://goreportcard.com/report/tailscale.com/client/tailscale/v2) |
There was a problem hiding this comment.
I probably wouldn't bother with this link, but YMMV.
| // SPDX-License-Identifier: MIT | ||
|
|
||
| // Package tsclient contains a basic implementation of a client for the Tailscale HTTP API. | ||
| // package tailscale contains a basic implementation of a client for the Tailscale HTTP API. |
There was a problem hiding this comment.
If our goal is to advertise this as the preferred standard client, maybe we should make this more explicit:
| // package tailscale contains a basic implementation of a client for the Tailscale HTTP API. | |
| // Package tailscale implements a client for the Tailscale HTTP API. |
Nit: Please capitalize "Package".
oxtoacart
force-pushed
the
percy/removev1
branch
2 times, most recently
from
cca8327 to
487390b
Compare
Updates tailscale/corp#22748 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/removev1
branch
from
487390b to
a629cca
Compare
| @@ -1,17 +1,55 @@ | |||
| # tailscale-client-go | |||
| # tailscale.com/client/tailscale/v2 | |||
There was a problem hiding this comment.
out of curiosity, how are we pulling that off? Are we planning to serve different go-get metadata at that URL? (sorry, I'm behind on the latest client package naming discussions)
3 participants
No description provided.