Conversation
taiki-e
changed the title
taiki-e
force-pushed
the
float
branch
11 times, most recently
from
43f3411 to
e7a3eda
Compare
|
@taiki-e since this is controlled by a cfg flag instead of a by a feature it doesn't seem possible to enable it when portable-atomic is a dependency. Is this intentional? |
Owner
Author
|
This is intentional, and it is the same reason why cfg is used for unstable APIs in tokio, proc-macro2, rayon, etc. |
Owner
Author
See rayon-rs/rayon#369, rayon-rs/rayon#364, https://github.com/dtolnay/proc-macro2#unstable-features, tokio-rs/tokio#1774 (comment), etc. for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
floatand unstable--cfg portable_atomic_unstable_f16are enabled,AtomicF16for unstablef16is also provided.floatand unstable--cfg portable_atomic_unstable_f128are enabled,AtomicF128for unstablef128is also provided.Note that unstable cfgs are outside of the normal semver guarantees and minor or patch versions of portable-atomic may make breaking changes to them at any time.