Pass RVCXX to tests; use ${RVCXX} instead of hard-coded compiler; fix copy-and-paste comments #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@kpgriesser : We use |
… copy-and-paste comments
Work around frflags instruction not implemented until Zicsr extension is added
Rename *.cpp to *.cc; use ${RVCXX} and ${CXX} for C++ compiler
Collaborator
|
All the changes look fine. Can you update the README.md so users know how to set these? The only mention in the document is this example: cmake -DRVCC=/path/to/riscv/compiler/exe. It would be good to clarify that these are associated with gcc and g++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RVCXXto Rev tests -- previously, onlyRVCCwas being passed${RVCXX}instead of a hard-coded compiler to compile C++ testsunordered_mapandunordered_map_objtests need to use the old hard-coded compilerriscv64‑unknown‑elf‑g++instead of${RVCXX}because if the correct C++ compiler is used, theunordered_mapcallsfloor()which uses thefrflagsinstruction which is pending on #238 being finished.