fix(webfont): bring back all, outlined variant of webfont#1511
Open
kakkokari-gtyih wants to merge 2 commits into
Open
fix(webfont): bring back all, outlined variant of webfont#1511kakkokari-gtyih wants to merge 2 commits into
all, outlined variant of webfont#1511kakkokari-gtyih wants to merge 2 commits into
Conversation
|
@kakkokari-gtyih is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
kakkokari-gtyih
commented
Apr 24, 2026
Comment on lines
+10
to
+13
| // Generate filled icons | ||
| const filledDirname = path.join(DIR, 'icons-filled'); | ||
| await processIcons(filledFiles, filledDirname, 'filled', DIR); | ||
| await generateFont('filled', 'filled', DIR); |
Author
There was a problem hiding this comment.
Since the filled variant is required to generate the all variant, I've changed the code to build the filled first.
| "build:prepare": "mkdir -p icons-outlined dist && rm -fdr dist/*", | ||
| "build:webfont": "rm -fd dist/fonts/* && node .build/build-webfont.mjs", | ||
| "build:css": "pnpm run build:css:outline && pnpm run build:css:filled", | ||
| "build:css": "pnpm run build:css:outline && pnpm run build:css:filled && pnpm run build:css:all", |
Author
There was a problem hiding this comment.
I've added the CSS generation for the all variant, as it was missing (but presented as an independent build script).
Comment on lines
-45
to
-49
| "dependencies": { | ||
| "@tabler/icons": "workspace:", | ||
| "svg-path-commander": "^2.1.11", | ||
| "svgtofont": "^6.5.0" | ||
| }, |
Author
There was a problem hiding this comment.
These dependencies are only needed at build time, so I moved them to devDependencies.
Author
|
Updated to current main branch. Are there anything I can do to move this forward? Thanks! |
|
✅ All icons are valid! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with v3.36.x, assets in the
tabler-icons-<weight>-outline.cssseries are no longer generated; instead, they are now generated astabler-icons-<weight>.css. As a result, there were no longer any variants that allowed the use of bothfilledandoutlinesimultaneously.This fix builds a new
allvariant after theoutlinebuild. In theallvariant, the-filledsuffix is appended to thefilledicon names (the same behavior as in versions prior to 3.35.0).Fix #1415
Fix #1452