Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News articles looked broken when it contained video as media and had "Show in views" set to "Show in all views". This request tries to fix most of these issues.
The video/iframe-tags were styled for news and the object-fit class were added to most Partials/List. As NewsCarousel.html is using MediaVideo-partial I added a local Partial-variant that uses the object-fit class.
Note: Item (List) was intentionally left more or less as it is. If I added maxWidth from plugin.tx_news.settings.media.image, it would not conform height-wise on youtube/vimeo (like image does) and it's also questionable what the use of a video-player, as big as a stamp, really is.
Attached are images in the five views before and after: Item (List), Timeline, Simple List, Carousel and Cards.
Item (List)
Timeline
Simple List
Carousel
Cards
