[FEATURE] added default column-value in 'Advanced one column grid'.#414
Merged
[FEATURE] added default column-value in 'Advanced one column grid'.#414
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to:
Adv2ColumnGrid
Adv3ColumnGrid
Adv4ColumnGrid
..let's set a default column-value. The main reason being consistency with the other Adv*ColumnGrid and to ensure that the Bootstrap .row / .col-*-* structure is kept.
An example is if you use Adv1ColumnGrid to add a container (both literally and the Bootstrap-terminology .container) in a fluid-container parent, you need to set a .col-*-* value as there is also a .row in between of the .container and the .col-*-*. Otherwise, the margin / padding structure will not be correct and in mobile view-ports you will typically get a horizontal scrollbar.
So it is for convenience - in the same way as it is for Adv2ColumnGrid and upwards. :) (...and can be overriden completely by users choice)