[FEATURE] alternative designs for language menu (Podio feature_82)#76
Open
yosokus wants to merge 2 commits intot3kit:lessfrom
Open
[FEATURE] alternative designs for language menu (Podio feature_82)#76yosokus wants to merge 2 commits intot3kit:lessfrom
yosokus wants to merge 2 commits intot3kit:lessfrom
Conversation
yosokus
commented
Feb 1, 2017
yosokus
commented
- [FEATURE] dropdown and fixed language menu css and javascript
* [FEATURE] dropdown and fixed language menu css and javascript
laurisaarni
reviewed
Feb 6, 2017
main.js
Outdated
| // toggle language menu (dropdown) | ||
| $('.js__language-navigation__toggle-btn').on('click', function(e) { | ||
| e.preventDefault(); | ||
| $('.js__language-navigation__items-wrp').not(':animated').slideToggle(300); |
There was a problem hiding this comment.
@yosokus Please collect number values as settings in centralized place above. Toggle Speed, min width etc. Now the min width value is repeated in the code.
Author
|
@laurisaarni I've done some code refactoring. Please review my codes and provide feedback. |
dmh
requested changes
Feb 16, 2017
Member
dmh
left a comment
dmh
left a comment
There was a problem hiding this comment.
less branch is generated automatically, so all changes should be added to master branch of felayout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.