fix: correctly transition from isearch to visual-replace #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `isearch-exit` will: 1. Recursively edit the current search string if empty and if `search-nonincremental-instead` is `t`. 2. Call `exit-recursive-edit` from `isearch-done` if `isearch-recursive-edit` is `t`. In my case, this is preventing me from switching to `visual-replace` from `isearch` because `isearch-recursive-edit` keeps getting set (which may be a different issue...). But, in general, this appears to be the correct way to do this: https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/isearch.el?h=57fe24961fd1df04c9df1ba790932d6545f729e8#n2404 Emacs also binds `isearch-recursive-edit` to `nil`: https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/isearch.el?h=57fe24961fd1df04c9df1ba790932d6545f729e8#n2397 But this seems unnecessary given the above change.
Owner
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
isearch-exitwill:search-nonincremental-insteadist.exit-recursive-editfromisearch-doneifisearch-recursive-editist.In my case, this is preventing me from switching to
visual-replacefromisearchbecauseisearch-recursive-editkeeps getting set (which may be a different issue...).But, in general, this appears to be the correct way to do this:
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/isearch.el?h=57fe24961fd1df04c9df1ba790932d6545f729e8#n2404
Emacs also binds
isearch-recursive-edittonil:https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/isearch.el?h=57fe24961fd1df04c9df1ba790932d6545f729e8#n2397
But this seems unnecessary given the above change.