Only parse profiles from subimages and includes if those are dirs#3423
Merged
daandemeyer merged 2 commits intosystemd:mainfrom Jan 24, 2025
Merged
Only parse profiles from subimages and includes if those are dirs#3423daandemeyer merged 2 commits intosystemd:mainfrom
daandemeyer merged 2 commits intosystemd:mainfrom
Conversation
daandemeyer
force-pushed
the
profile
branch
3 times, most recently
from
a97972d to
e793573
Compare
With all the chdir() we do while parsing configuration, let's make sure our config paths are absolute so that they don't suddenly change meaning when we chdir().
behrmann
approved these changes
Jan 24, 2025
| s: Optional[ConfigSetting[object]] # Hint to mypy that we might assign None | ||
| extras = path.is_dir() | ||
|
|
||
| assert path.is_absolute() |
Contributor
There was a problem hiding this comment.
For typing assert is fine, but we shouldn't use it for errors.
Suggested change
| assert path.is_absolute() | |
| if not path.is_absolute(): | |
| raise ValueError(f'{path} is not absolute') |
Contributor
Author
There was a problem hiding this comment.
@behrmann This is a programming error, not a user error, so an assert fits better imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.