Skip to content

Conversation

@crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Oct 18, 2021

  • Update toolchain to 2021-06-15 (version used by Redox)
  • Update dependencies and fix build
  • Enable mem feature of compiler-builtins
  • Fix clippy warnings

llvm_asm!() is deprecated, but must be used. The new asm!() does not allow using ebx (rust-lang/rust#84658), which holds the argument for the SMMSTORE command.

@crawfxrd crawfxrd marked this pull request as ready for review October 19, 2021 20:51
Update toolchain to match the version used in Redox.

Update dependencies and fix build.

Signed-off-by: Tim Crawford <[email protected]>
Replace the deprecated rlibc library with the compiler-builtins
intrinsics. Requires a toolchain newer than 2020-09-30.

Signed-off-by: Tim Crawford <[email protected]>
Fix:
- clippy::needless_borrow
- clippy::bool_assert_comparison

Silence:
- clippy::manual_flatten

Not addressed:
- deprecated

`llvm_asm!()` is deprecated, but must be used. The new `asm!()` does not
allow using `ebx` [1], which holds the argument for the SMMSTORE command.

[1]: rust-lang/rust#84658

Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd crawfxrd merged commit 00c44d4 into master Oct 28, 2021
@crawfxrd crawfxrd deleted the update-toolchain branch October 28, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants