Skip to content

docs: expand docs on meta theme-color#2134

Merged
lachlanjc merged 4 commits into
developfrom
theme-color-misleading
Mar 29, 2022
Merged

docs: expand docs on meta theme-color#2134
lachlanjc merged 4 commits into
developfrom
theme-color-misleading

Conversation

@hasparus

@hasparus hasparus commented Feb 15, 2022

Copy link
Copy Markdown
Member

I've expanded the docs on meta theme color to present some more alternatives.


Further reading: https://css-tricks.com/meta-theme-color-and-trickery/

@hasparus hasparus requested a review from lachlanjc as a code owner February 15, 2022 09:37
@vercel

vercel Bot commented Feb 15, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/6swr4UNPe9uY6q1oSykmzi991qQT
✅ Preview: https://theme-ui-git-theme-color-misleading-systemui.vercel.app

@hasparus hasparus added the documentation Changes only affect the documentation label Feb 15, 2022
@codesandbox-ci

codesandbox-ci Bot commented Feb 15, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c69043b:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@lachlanjc

Copy link
Copy Markdown
Member

Does anybody actually want a blue browser top bar?

Uhhh yeah I do :)

Maybe we just clarify you can use any of your colors depending on how bold a look you want?

@hasparus

Copy link
Copy Markdown
Member Author

Uhhh yeah I do :)

you monster xD

Maybe we just clarify you can use any of your colors depending on how bold a look you want?

Definitely. I'll go back to it and try writing something more informative here.

@hasparus hasparus changed the title docs: stop advising people to use primary as theme-color docs: expand docs on meta theme-color Mar 21, 2022
@hasparus hasparus force-pushed the theme-color-misleading branch from c220499 to 291339b Compare March 21, 2022 11:41
Comment thread packages/docs/src/pages/guides/theme-color-meta-tag.mdx Outdated
Comment thread packages/docs/src/pages/guides/theme-color-meta-tag.mdx Outdated
Co-authored-by: Lachlan Campbell <lachlanjc@hey.com>
Co-authored-by: Lachlan Campbell <lachlanjc@hey.com>
@lachlanjc lachlanjc merged commit f005a92 into develop Mar 29, 2022
@lachlanjc lachlanjc deleted the theme-color-misleading branch March 29, 2022 06:32
@hasparus hasparus added the prerelease This change is available in a prerelease. label Mar 31, 2022
@hasparus

Copy link
Copy Markdown
Member Author

🚀 PR was released in v0.14.2 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes only affect the documentation released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants