[AF-402] Fix model reinitialization issues with viewport and internal…#523
Merged
piotrblaszczyk merged 2 commits intomainfrom Jan 15, 2026
Merged
[AF-402] Fix model reinitialization issues with viewport and internal…#523piotrblaszczyk merged 2 commits intomainfrom
piotrblaszczyk merged 2 commits intomainfrom
Conversation
lukasz-jazwa
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues occurred when reinitializing the same model:
Viewport issues: After model reinitialization,
zoomToFitdidn't work and linking operations moved the whole viewport. Root cause:viewport.widthandviewport.heightwereundefinedbecauseResizeObserverdoesn't fire when element size hasn't changed.Angular tracking issues: When the same model with identical node IDs was reinitialized, Angular's
@forloop withtrackByusingidcouldn't distinguish between old and new nodes. The_internalId(used for forcing view recreation) was only assigned by middleware when nodes were added via transactions, not during initial model creation.Solution
Viewport fix: Added
getViewportSize()callback toFlowCoreand callinitializeViewportSize()beforerender()to ensure viewport dimensions are set from element'sgetBoundingClientRect()on every initialization.Internal ID fix:
_internalIdis now assigned duringinitializeModel()as well, not only when adding nodes via middleware.