[WIP] moving to Symfony2.1 and using the CMF for content rendering #6
Conversation
|
seems i can't comment on the file mode change, but why make .htaccess executable? that one makes no sense. |
There was a problem hiding this comment.
should we not rather create a custom menu provider than a renderer? this has nothing to do with rendering...
There was a problem hiding this comment.
Works for me. However, I've never played with a menu provider before. Do you have any example somewhere, which works with the latest version of Symfony and the CMF?
|
there is also other files that go to 755 instead of 644 that should be changed back. and one more question: why remove the compiled slidesets from web/slides/* ? afaik we do not provide them anywhere else and they are useful introduction. |
|
I added the compiled slides in the web folder, the tests, readme and homepage have been updated. About the file permissions (755 instead of 644), can I do something about it? I'm not sure to get the problem... I'm now waiting for instructions about the menu renderer... |
ghost
assigned
|
I think the work is done. Tell me if you see anything that could be improved. |
.gitignore
Outdated
There was a problem hiding this comment.
why do you ignore web/js and web/css?
There was a problem hiding this comment.
because I thought it should be installed with app/console assets:install. but when thinking about it it would mean that someone cloning the repository should type that command before using the site. I will remove it.
There was a problem hiding this comment.
because I thought it should be installed with app/console assets:install. but when thinking about it it would mean that someone cloning the repository should type that command before using the site. I will remove it.
assets:install only creates the web/bundles dir
There was a problem hiding this comment.
just for completeness: if we would use assetic, you would also want to ignore web/assets/ because assetic:dump renders js and css into that folder.
There was a problem hiding this comment.
imho we can merge this, but:
@lsmith77 what do you think about this one? we could also have handled this like an "external" link but that sounds stupid and would be hardcoding information. eventually we should probably do something on the cmf MenuBundle to allow rendering the root of the menu as home link.
should we create a ticket on MenuBundle so we don't forget?
|
looks good to me, thanks everybody who worked on this! can we deploy like this on cmf.symfony.com or do we need to talk with somebody? now the next step would be to add CreateBundle and do some editing :-) but then we need access protection... |
|
i can deploy it .. |
|
merged |
[WIP] moving to Symfony2.1 and using the CMF for content rendering
@adou600 @mjanser @leahaense great work
I have created the PR so that we can coordinate the finalization of the changes.
One thing I just noticed is that the stuff in app/tests should be updated to the new fixtures.
Also the README.md should be adjusted.
I havent tested it all, but from what I saw it looks like you guys did an awesome job.