[core] Install packages in order of declaration #17177
Conversation
The installation order of packages got reversed in fbe05e3. Appending is slower than cl-pushnew, of course, but this is the same as what add-to-list did before, and it should not be noticable with a few hundred packages.
In particular, do not install packages in alphabetical order. This means one can manually manage dependencies for packages installed via quelpa recipes, addressing syl20bnr#17176. This change should be safe, also the order of package installations was reversed before without obvious regressions (see previous commit). Note that we still use the alphabetically sorted list of packages in other contexts, such as when configuring packages, mostly for backward compatibility.
fnussbaum
force-pushed
the
install-packages-declared-order
branch
from
e2f1e7d to
68c1a5d
Compare
|
Installing packages in (reverse) alphabetic order is arbitrary, inflexible and can lead to problems as evidenced by #17176. Consider also the openai layer: spacemacs/layers/+web-services/openai/packages.el Lines 23 to 27 in ccd3e20 Here, none of the packages are available on GNU/Non-GNU ELPA or MELPA, and I skimmed through all instances of packages declared to get installed via quelpa, and it does not look like this change would break anything (in any case, it would be a simple matter to change the order of package declarations). In most other cases, the installation order should not make a difference. |
|
By the way, the reason for why we manually need to manage installation order for dependencies of quelpa-installed packages is that we cannot fetch the dependencies from Perhaps we could, alternatively, first clone all of the quelpa packages without installing them, and then look up their dependencies to determine the installation order. But this would be a more involved change. On the other hand, with the change of this PR, we would make the installation order of packages depend on the order of layers in |
This might indeed be better, I'll mark this PR as a draft. Sorry for the noise. |
1 participant
In particular, do not install packages in alphabetical order. This means one can manually manage dependencies for packages installed via quelpa, addressing #17176. This change should be safe, also the order of package installations was approximately reversed before without obvious regressions (see this PR's first commit).
Note that we still use the alphabetically sorted list of packages in other contexts, such as when configuring packages, mostly for backward compatibility.