Open
Conversation
| ## checks for the sake of performance and use straight-up list subsetting | ||
| ## (which will use underlying C code). | ||
| class(data) <- "list" | ||
| class(data) <- "list" # If you've overwritten `class<-` globally then too bad. |
Member
There was a problem hiding this comment.
Or isTRUE, assign, (, etc. lol
| ## has been accidentally overwritten (e.g., if someone makes a | ||
| ## global `substitute` variable that points to a function). | ||
| ## | ||
| ## Yes, people are silly, and this does sometimes happen! |
Member
There was a problem hiding this comment.
I think this is generally a good idea.
Member
Author
|
Some failing tests. I'll address later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@abelcastilloavant @peterhurford @kirillseva This little snaggler came up when I had a global variable
match <- function(...) { foo }, since it gets used in the body of column transformations, which passes throughglobalenv()when searching parent environments.I think this may be too slow for column transformation, however, given that under the hood we are calling
repeatedly. Potentially a better alternative is to do the silly thing and copy those aliases
match <- base::matchinto the package and shadow them directly for a boost. I'll do some benchmarks tomorrow.Also need to change
multi_column_transformation.