Skip to content

Make complete_part more robust#547

Open
rduque1 wants to merge 3 commits intoswirldev:masterfrom
datacamp:master
Open

Make complete_part more robust#547
rduque1 wants to merge 3 commits intoswirldev:masterfrom
datacamp:master

Conversation

@rduque1
Copy link

@rduque1 rduque1 commented Oct 5, 2016

When working with swirl on DataCamp, it happens that the e$test_from exceeds the actual number of exercises in the lesson. This gave nasty side effects.

I added an extra check that only does complete_part() if e$test_from is lower than nrow(e$les). Otherwise, e$test_from is simply reset to 1.

up_through should never be higher than the total number of exercises in a lesson.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant