Fix build on nightly rustc #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
commented
May 27, 2017
| @@ -1,8 +1,3 @@ | |||
| // I don't see **any** reason for this waring to enabled. We only build binary | |||
| // and most of these warnings do not apply to real visibility of types inside | |||
| // the crate | |||
Contributor
Author
There was a problem hiding this comment.
The logic is that private types cannot be leaked from modules they are defined in, so if you see a private type you have a guarantee that it's restricted to this module.
These crate wants to leak private types like UpstreamValidator from their module, therefore the error.
If UpstreamValidator and friends are intended to be implementation details (1), but still leaked in some form (2) (e.g. through aliases), they have to be marked as pub (because 2), but made "unnameable" by placing them into a private module (because 1).
(The tracking issue for private_in_public contains a similar example.)
Collaborator
|
Good to know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
rust-lang/rust#42125 is going to turn some old compatibility "private-in-public" warnings in
rustcinto hard errors.crates.iotesting discovered that published version of this crate is affected by one of those errors.This PR updates the code to build successfully with rust-lang/rust#42125