Make Feature a struct enum so we can put methods on it. #79891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
CodaFi,
DougGregor,
ahoppen,
artemcm,
bnbarham,
eeckstein,
hamishknight,
hborla,
kavon,
rintaro,
slavapestov,
tshortli and
xedin
as code owners
gottesmm
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
3638a83 to
34c22ba
Compare
Contributor
Author
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
34c22ba to
7f32376
Compare
Contributor
Author
|
@swift-ci smoke test |
AnthonyLatsis
approved these changes
Mar 11, 2025
gottesmm
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
7f32376 to
aa4625d
Compare
Contributor
Author
|
@swift-ci smoke test |
AnthonyLatsis
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
aa4625d to
9088a6a
Compare
Collaborator
|
@swift-ci please smoke test macOS |
AnthonyLatsis
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
9088a6a to
a35c49c
Compare
Collaborator
|
@swift-ci please smoke test macOS |
Collaborator
|
@swift-ci please smoke test Linux |
Collaborator
|
@swift-ci please smoke test Windows |
AnthonyLatsis
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
a35c49c to
5cc600f
Compare
Collaborator
|
@swift-ci please smoke test |
Just noticed this as I was looking at making other changes.
AnthonyLatsis
force-pushed
the
pr-9df6772bb44656cbd85cad72ee5c3637caab8956
branch
from
5cc600f to
3ff9463
Compare
Collaborator
|
@swift-ci please smoke test |
Collaborator
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this as I was looking at making other changes.