Skip to content

Conversation

@stevapple
Copy link
Contributor

C++ STL from MSVC 14.40 and newer versions require Clang 17+ to build. Swift 5.10.1 is no longer capable, but thankfully we have 6.0 now.

We also replaced the nightly toolchain used by the ARM64 build to a newer one.

…compatibility

C++ STL from MSVC 14.40 and newer versions require Clang 17+ to build. Swift 5.10.1 is no longer capable, but thankfully we have 6.0 now.
@stevapple stevapple changed the title [build.ps1] Update default pinned toolchain to 6.0.0 for MSVC 14.40+ compatibility [build.ps1] Pin Swift 6.0.0 for MSVC 14.40+ compatibility Sep 19, 2024
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really acceptable, we are using 5.10 explicitly because that is the version that is agreed upon as the baseline for bootstrapping.

@stevapple
Copy link
Contributor Author

stevapple commented Sep 19, 2024

@compnerd The Windows on ARM build is already using (a snapshot of) Swift 6.0. An alternative is to fix MSVC version in CI and document that anyone who wants to build a Windows toolchain either needs to provide a custom Swift 6.0 toolchain or to use MSVC 14.39-.

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we need to maintain the invariant that an older compiler can compile the current compiler. The patch for handling static_assert(false ...) for the new Windows SDK has already been backported and will be part of a future 5.10 release dot release, so we should use that once it is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants