Copy Testing modules/binaries in Install-Platform #76352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
swiftlang/swift-foundation#908 @swift-ci please smoke test |
Contributor
Author
|
swiftlang/swift-foundation#908 @swift-ci please smoke test |
Contributor
Author
|
swiftlang/swift-foundation#908 @swift-ci please smoke test |
Contributor
Author
|
swiftlang/swift-foundation#908 @swift-ci please smoke test windows platform |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
There are other lingering issues in SwiftPM that prevent Foundation from adopting swift-testing at the moment. We're working on those separately, but this PR at least passes CI without the Foundation change and with the Foundation change the previous CI runs validated that this works as expected. @compnerd / @grynspan any opposition to merging this while we work on the SwiftPM issue in parallel? |
Contributor
Author
Member
I don't see a good reason to hold off on this. This is just changing the installed image and the staged install.
Contributor
|
Ship it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to XCTest, we need to copy the
Testingmodules/binaries to the staged toolchain so that downstream clients (like Foundation's unit tests) can find them.