[6.0][Concurrency] Stage in new Async{Throwing}Stream.init(unfolding:) errors as warnings.#73360
Merged
hborla merged 3 commits intoMay 1, 2024
Merged
Conversation
…rrors as warnings. Marking the closure parameter to these inits as `@Sendable` changed the inferred isolation of closure arguments in actor-isolated contexts, which caused new effects checker errors when accessing isolated properties and methods without `await`. Mark these `init`s as `@preconcurrency`, and fix the effects checker to downgrade those errors to warnings when the context of the call is `@preconcurrency`. (cherry picked from commit 38cc951)
…Cancel:)`. (cherry picked from commit 2c20902)
(cherry picked from commit 7f5e47e)
Member
Author
|
@swift-ci please test |
DougGregor
approved these changes
May 1, 2024
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This is a nice way to stage in this change, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async{Throwing}Stream.init(unfolding:)as@Sendablechanged the inferred isolation of closure arguments in actor-isolated contexts, which caused new effects checker errors when accessing isolated properties and methods withoutawait. Mark theseinits as@preconcurrency, and fix the effects checker to downgrade those errors to warnings when the context of the call is@preconcurrency.Async{Throwing}Stream.init(unfolding:)errors as warnings. #73310