[5.9][Driver] Derive '-external-plugin-path' #65669
Merged
+134
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
Member
Author
|
@swift-ci Please test |
When the current toolchain is not a Xcode toolchain, derive '-external-plugin-path' poinintng Xcode plugins paths, so we can use plugins in Xcode. rdar://108624128 (cherry picked from commit b0f5c39)
rintaro
force-pushed
the
5.9-driver-external-plugin-path-rdar108624128
branch
from
5d20a3a to
c0c13a8
Compare
Member
Author
|
@swift-ci Please test |
DougGregor
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #65473 into release/5.9
Explanation: When the current toolchain is not a Xcode toolchain, derive '-external-plugin-path' poinintng Xcode plugins paths, so toolchains from
swift.orgcan use plugins in Xcode. This change corresponds to swiftlang/swift-driver#1340Scope: Legacy C++ libDriver users (only SourceKit) in non-Xcode toolchains
Risk: Low
Testig: Passes exiting test-suite
Issue: rdar://108624128
Reviewer: Ben Barham (@bnbarham)