Skip to content

EscapeAnalysis: add support for access markers. #29534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atrick merged 1 commit into from
Jan 29, 2020
Merged

EscapeAnalysis: add support for access markers. #29534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/SILOptimizer/Analysis/EscapeAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ SILValue EscapeAnalysis::getPointerBase(SILValue value) {
case ValueKind::StructElementAddrInst:
case ValueKind::StructExtractInst:
case ValueKind::TupleElementAddrInst:
case ValueKind::BeginAccessInst:
case ValueKind::UncheckedTakeEnumDataAddrInst:
case ValueKind::UncheckedEnumDataInst:
case ValueKind::MarkDependenceInst:
Expand Down
22 changes: 22 additions & 0 deletions test/SILOptimizer/escape_analysis.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,3 +1888,25 @@ bb0(%0 : @guaranteed $@sil_unowned Builtin.NativeObject):
%1 = strong_copy_unowned_value %0 : $@sil_unowned Builtin.NativeObject
return %1 : $Builtin.NativeObject
}

// Test begin_access. It should look like a derived pointer.
// CHECK-LABEL: CG of testAccessMarkerHelper
sil hidden @testAccessMarkerHelper : $@convention(thin) (@inout SomeData) -> () {
bb0(%0 : $*SomeData):
%1 = tuple ()
return %1 : $()
}

// CHECK-LABEL: CG of testAccessMarker
// CHECK-NEXT: Arg %0 Esc: A, Succ: (%0.1)
// CHECK-NEXT: Con [ref] %0.1 Esc: G, Succ:
// CHECK-LABEL: End
sil hidden @testAccessMarker : $@convention(thin) (@inout SomeData) -> () {
bb0(%0 : $*SomeData):
%1 = begin_access [modify] [static] %0 : $*SomeData
%2 = function_ref @testAccessMarkerHelper : $@convention(thin) (@inout SomeData) -> ()
%3 = apply %2(%1) : $@convention(thin) (@inout SomeData) -> ()
end_access %1 : $*SomeData
%5 = tuple ()
return %5 : $()
}