Skip to content

Use https instead of git@ for cloning instructions#29

Closed
kylef wants to merge 1 commit into
swiftlang:masterfrom
kylef:patch-1
Closed

Use https instead of git@ for cloning instructions#29
kylef wants to merge 1 commit into
swiftlang:masterfrom
kylef:patch-1

Conversation

@kylef

@kylef kylef commented Dec 3, 2015

Copy link
Copy Markdown

Cloning with git@ uses SSH and thus requires the user to have an account on GitHub and have an SSH key locally configured and attached to their GitHub account.

Changing this to https removes these dependencies for users following instructions on the README.

This also updates links to ninja build repository and their new website.

@jorng

jorng commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

This should really be two different requests. You've also included a URL change for Ninja

@BrandonMathis

Copy link
Copy Markdown
Contributor

Excellent suggestion! I've updated my own PR #31 to include this change

@alfwatt

alfwatt commented Dec 3, 2015

Copy link
Copy Markdown

+1

@glittershark

Copy link
Copy Markdown

why not git://?

@vamsi

vamsi commented Dec 3, 2015

Copy link
Copy Markdown

+1

@vocaro

vocaro commented Dec 3, 2015

Copy link
Copy Markdown

What about users who prefer SSH connections so that they don't have to enter a username and password every time they clone something?

@kylef

kylef commented Dec 3, 2015

Copy link
Copy Markdown
Author

@vocaro This is a public repository so you wouldn't need to enter a username or password.

@daknob

daknob commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

+1 (:+1:)

@takebayashi

Copy link
Copy Markdown
Contributor

+1

@AquaGeek

AquaGeek commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

I think you can configure your git settings to override it for you via insteadOf.

@Haroenv Haroenv mentioned this pull request Dec 4, 2015
@evieluvsrainbows

Copy link
Copy Markdown

This is really pointless. People should just create a GitHub account and SSH key. It takes less than 2 minutes to do so.

@kkirsche

kkirsche commented Dec 4, 2015

Copy link
Copy Markdown

@KamranMackey Swift, a project on Github, should follow Github's recommendations for method of cloning not user / your preference.

https://help.github.com/articles/which-remote-url-should-i-use/#cloning-with-https-recommended

@tkremenek

Copy link
Copy Markdown
Member

This is now resolved by 15428fb.

@tkremenek tkremenek closed this Dec 4, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Initialise dispatch_queue_attr_concurrent on Linux
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Initialise dispatch_queue_attr_concurrent on Linux

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
lorentey added a commit to lorentey/swift that referenced this pull request Aug 6, 2025
…ndaries

Carefully overhaul our word breaking implementation to follow the recommendations of Unicode Annex swiftlang#29. Start exposing the core primitives (as well as `String`-level interfaces), so that folks can prototype proper API for these concepts.

- Fix `_wordIndex(after:)` to always advance forward. It now requires its input index to be on a word boundary. Remove the `@_spi` attribute, exposing it as a (hidden, but) public entry point.
- The old SPIs `_wordIndex(before:)` and `_nearestWordIndex(atOrBelow:)` were irredemably broken; follow the Unicode recommendation for implementing random-access text segmentation and replace them both with a new public `_wordIndex(somewhereAtOrBefore:)` entry pont.
- Expose handcrafted low-level state machines for detecting word boundaries (_WordRecognizer`, `_RandomAccessWordRecognizer`), following the design of `_CharacterRecognizer`.
- Add tests to reliably validate that the two state machine flavors always produce consistent results.

rdar://155482680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.