Fix logic error in ArchetypeBuilder::mapTypeIntoContext#266
Merged
DougGregor merged 1 commit intoswiftlang:masterfrom Dec 7, 2015
Merged
Fix logic error in ArchetypeBuilder::mapTypeIntoContext#266DougGregor merged 1 commit intoswiftlang:masterfrom
DougGregor merged 1 commit intoswiftlang:masterfrom
Conversation
Contributor
|
Uhm, +1 awesome. @DougGregor, please review when you get a chance. |
Member
|
Oh, that's just embarrassing. Thank you! |
DougGregor
added a commit
that referenced
this pull request
Dec 7, 2015
Fix logic error in ArchetypeBuilder::mapTypeIntoContext
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
build: remove dead code
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
build: remove dead code Signed-off-by: Daniel A. Steffen <[email protected]>
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Xfail fluent and SwiftLint due to SR-9029
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
WiX: add a new bundle upgrade code for 5.10 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a pretty simple fix. I'm amazed that the code in question is 2 years old, and somehow never caused enough problems for it to show up anywhere besides fuzz tests!
Fixes 47 compiler_crashers. 🔧