[benchmark] run_smoke_bench tweaks #20667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that used hashing were being unnecessarily tested multiple times, because this environment variable was missing.
Contributor
Author
|
@eeckstein Please review 🙏 |
Allow for running of test matching the naming convention proposed in swiftlang#20334.
palimondo
force-pushed
the
cells-interlinked
branch
from
53692f1 to
4e5f51d
Compare
This was referenced Nov 17, 2018
Contributor
|
@swift-ci benchmark |
1 similar comment
Contributor
|
@swift-ci benchmark |
Contributor
|
@swift-ci smoke test |
1 similar comment
Contributor
|
@swift-ci smoke test |
Contributor
Build comment file:No performance and code size changes |
Contributor
Author
|
Thank you Erik! |
Contributor
Author
|
@eeckstein just quick a reminder from above, as it looks like #20769 also uses periods in names:
|
Member
|
If the dots cause any trouble, I can still change them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes:
The naming change is to allow for measuring tests conforming to proposed naming convention in #20334 (only partial support for
.and-, for now without!and?), like the #20552 and #20666.If these get accepted, the Apple-internal script that measures benchmarks and submits them to LNT should also be updated to work with such names.