Skip to content

command plugins: Build command plugin dependencies for the host, not the target #7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
euanh merged 2 commits into from
Jan 23, 2024
Merged

command plugins: Build command plugin dependencies for the host, not the target #7280

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d7a047
command plugins: Build command plugin dependencies for the host, not …
euanh Jan 19, 2024
cb58af8
command plugins: Test dependencies are always built for the host
euanh Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/Commands/PackageTools/PluginCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,11 @@ struct PluginCommand: SwiftCommand {
// Build or bring up-to-date any executable host-side tools on which this plugin depends. Add them and any binary dependencies to the tool-names-to-path map.
let buildSystem = try swiftTool.createBuildSystem(
explicitBuildSystem: .native,
cacheBuildManifest: false
cacheBuildManifest: false,
// Force all dependencies to be built for the host, to work around the fact that BuildOperation.plan
// knows to compile build tool plugin dependencies for the host but does not do the same for command
// plugins.
productsBuildParameters: buildParameters
)
let accessibleTools = try plugin.processAccessibleTools(
packageGraph: packageGraph,
Expand Down