Skip to content

Conversation

@bnbarham
Copy link
Contributor

Reverts #1004. Possibly the cause of Windows CI failures, will run cross PR testing to check.

@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

https://ci-external.swift.org/job/swift-PR-windows/44372/ is the swift cross-pr testing run. Though I'm not sure how they could be different 🤔

@bnbarham
Copy link
Contributor Author

Going to merge this to unblock CI. Note that from what I can see in the logs, the PR testing in the original job didn't actually test the change:

Checking out Revision f36582cf601212160fdde492ae5b17b2846f2030 (refs/remotes/origin/pr/1004/merge)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f36582cf601212160fdde492ae5b17b2846f2030 # timeout=10
Commit message: "Merge bb4eef80525011a5a3d3153d881b543746926d8d into 5891ce06197da2ed99099bf82c389eab6fdc0fd9"
...
update-checkout succeeded
...
llbuild                            : 5891ce06197da2ed99099bf82c389eab6fdc0fd9

Will look into that separately.

@bnbarham bnbarham merged commit cbac2d9 into main Aug 15, 2025
1 of 4 checks passed
@bnbarham bnbarham deleted the revert-1004-windows_long_file_fix branch August 15, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants